[vlc-devel] [PATCH 10/10] vlc_tick: add VLC_TICK_EPSILON to express the tiniest vlc_tick_t that can be used

[Steve Lhomme]

For me it's a way to mark code that should be looked at twice. In many
case it's probably just VLC_TS_0 used with its actual value.In other it could be legitimate to have a one tick shift for internal
use and it should be advertised as such instead of wondering if it's
correct or not.
I forgot to mention these lines:

http://git.videolan.org/?p=vlc.git;a=blob;f=modules/access/dvdnav.c;h=b20cb4d6a52ecdbed520f817028c5c4aab282b45;hb=HEAD#l1401http://git.videolan.org/?p=vlc.git;a=blob;f=modules/access/imem.c;h=edbb52566913b2460523f4685226e5a627a4dfc7;hb=HEAD#l575http://git.videolan.org/?p=vlc.git;a=blob;f=modules/access/imem.c;h=edbb52566913b2460523f4685226e5a627a4dfc7;hb=HEAD#l597http://git.videolan.org/?p=vlc.git;a=blob;f=modules/access/imem.c;h=edbb52566913b2460523f4685226e5a627a4dfc7;hb=HEAD#l598[1]http://git.videolan.org/?p=vlc.git;a=blob;f=modules/codec/libmpeg2.c;h=2dcf094c73cfd2c997d129b901668dbc54e62278;hb=HEAD#l580http://git.videolan.org/?p=vlc.git;a=blob;f=modules/codec/synchro.c;h=8285d8c00b05b8e2194deb08b2be7c4a9b6a22c7;hb=HEAD#l253http://git.videolan.org/?p=vlc.git;a=blob;f=modules/codec/ttml/substtml.c;h=fc6cec26413addff9b43a819edaac231997bf9c8;hb=HEAD#l1280http://git.videolan.org/?p=vlc.git;a=blob;f=modules/demux/flac.c;h=135354422bbdb517735f5026bdd792bdacb4be6e;hb=HEAD#l392http://git.videolan.org/?p=vlc.git;a=blob;f=modules/demux/ttml.c;h=557db4e1e13e0069d7a59f65056e2d4a9c88c595;hb=HEAD#l354http://git.videolan.org/?p=vlc.git;a=blob;f=modules/demux/vobsub.c;h=f3a93d432867497fbfdf4fd202de44cb4aa653e3;hb=HEAD#l372http://git.videolan.org/?p=vlc.git;a=blob;f=src/audio_output/dec.c;h=4f90c04d3c1dc55886c8a95be18f1aa1358baa3f;hb=HEAD#l384http://git.videolan.org/?p=vlc.git;a=blob;f=src/input/decoder.c;h=411f91371560f5982a5010430935f68beeaf5619;hb=HEAD#l778http://git.videolan.org/?p=vlc.git;a=blob;f=src/input/es_out.c;h=d36fd2c4fff672b301cdff12a19f8f76ee2e8047;hb=HEAD#l837http://git.videolan.org/?p=vlc.git;a=blob;f=src/input/resource.c;h=f806cfeb2c98fc829e69c8d6490b9ea95a332294;hb=HEAD#l276http://git.videolan.org/?p=vlc.git;a=blob;f=src/video_output/video_output.c;h=d9855a868db3966bebd4af917a7356914212cd03;hb=HEAD#l980
There are also calls to vlc_timer_schedule() with 1 to means the timer
should trigger right now (or the next clock tick). Rather than 0. IMO
that would be a good case for using VLC_TICK_EPSILON.
As you can see from the amount IMO it's better to mark them before we
forget about them for a long time.

Links:

  1. http://git.videolan.org/?p=vlc.git;a=blob;f=modules/access/imem.c;h=edbb52566913b2460523f4685226e5a627a4dfc7;hb=HEAD#l597
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180624/78644709/attachment.html>