[vlc-devel] [RFC PATCH 7/8] TMP: Instantiate media library from playlist

Hugo Beauzée-Luyssen hugo at beauzee.fr
Mon Jun 25 14:07:46 CEST 2018


On Mon, Jun 25, 2018, at 5:06 AM, Francois Cartegnie wrote:
> Le 25/06/2018 à 10:10, Hugo Beauzée-Luyssen a écrit :
> > @@ -226,6 +227,13 @@ playlist_t *playlist_Create( vlc_object_t *p_parent )
> >      p_playlist->root.i_id = 0;
> >      p_playlist->root.i_flags = 0;
> >  
> > +    if( var_InheritBool( p_parent, "media-library") )
> > +    {
> > +        p_playlist->p_media_library = vlc_ml_create( p_playlist );
> > +        if ( p_playlist->p_media_library == NULL )
> > +            abort();
> > +    }
> 
> I don't think we should "abort" if the module is missing or can't load
> for some reason (sql index corrupted ?)
> 

I agree, this commit is just a temporary way to instantiate the medialib.

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr


More information about the vlc-devel mailing list