[vlc-devel] [PATCH 2/2] vlc_block: store per block ancillary

[Rémi Denis-Courmont]

Le lundi 25 juin 2018, 13:14:25 EEST Jean-Baptiste Kempf a écrit :
> On Tue, 19 Jun 2018, at 19:22, Rémi Denis-Courmont wrote:
> > This is out of place. Block_t is a generic data structure, not some demux/
> > codec internal.
> 
> It is not a generic data_structure, since it contains flags (deinterlacing,
> I/P/B, tff/bff, etc..) and has pts and dts or preroll.

Flags is actually the most generic of all meta-data field in there, as it 
carries the generic corrupt flag and the mostly generic discontinuity flag. 
The remaining space is left for ad-hoc use for convenience.

If anything, the least generic of the grandfathered fields is DTS.

> If we want to have a block as a generic input data structure, we can have a
> different structure,

Yeah, if you want to extend the existing generic block data  structure, you 
can make a sub-class.

> but that is not what we have currently.

It is. Just check all the places that block_t is used for. It's far from only 
ES coded data.

-- 
Rémi Denis-Courmont