[vlc-devel] [V3 0/5] add rv34_parser to fix RV30/RV40 timestamp issue

[Zhao Zhili]

Ping again.

If it's overkill to add a packetizer for RV30/RV40, dropping the support 
in mkv module and fallback to avformat is another option.

I can make 4/5 and 5/5 in another patch group if it worth to support 
force select a module with demux_PacketizerNew.


On 2018年06月05日 16:50, Zhao Zhili wrote:
>
> Please review, thanks!
>
> On 2018年06月01日 23:20, Zhao Zhili wrote:
>> 1. Add the original author in license header
>>
>> 2.
>>> If the timestamps are changed on the fly, not just interpolation,
>>> I hardly see how that can work, no longer matching the pcr timestamps.
>> Now the packetizer is used inside mkv demux, the problem should be
>> resolved.
>>
>> 3. Reordered to avoid forward declaration of Open()/Close()
>>
>> 4. Fix the key_dts/key_pts unit.
>> key_dts just records block->i_pts so it has the same unit as
>> block->i_pts (and
>> the same variable type), kep_pts records the timestamp in bitstream in
>> unit of
>> milliseconds.
>>
>> 5. use vlc_obj_malloc and remove Close()
>>
>> Zhao Zhili (5):
>>    packetizer: add rv34_parser
>>    demux: mkv: reindent
>>    demux: mkv: fix timestamp issue of RV30/RV40
>>    demux: support force select a module with demux_PacketizerNew
>>    packetizer: add some shortcuts
>>
>>   include/vlc_demux.h                    |   3 +-
>>   modules/demux/flac.c                   |   2 +-
>>   modules/demux/mkv/matroska_segment.cpp |  14 ++++
>>   modules/demux/mkv/mkv.cpp              |  59 +++++++++------
>>   modules/demux/mkv/mkv.hpp              |   2 +
>>   modules/demux/mpeg/es.c                |   2 +-
>>   modules/demux/mpeg/h26x.c              |   3 +-
>>   modules/demux/mpeg/mpgv.c              |   2 +-
>>   modules/demux/vc1.c                    |   2 +-
>>   modules/packetizer/Makefile.am         |   2 +
>>   modules/packetizer/flac.c              |   1 +
>>   modules/packetizer/h264.c              |   1 +
>>   modules/packetizer/hevc.c              |   1 +
>>   modules/packetizer/mpegvideo.c         |   2 +
>>   modules/packetizer/rv34_parser.c       | 127 
>> +++++++++++++++++++++++++++++++++
>>   modules/packetizer/vc1.c               |   1 +
>>   src/input/demux.c                      |   8 ++-
>>   17 files changed, 203 insertions(+), 29 deletions(-)
>>   create mode 100644 modules/packetizer/rv34_parser.c
>>
>