[vlc-devel] [RFC PATCH 12/13] FIXUP: fix preroll with !pulse aouts
dheitmueller at kernellabs.com
Wed Jun 27 14:52:22 CEST 2018
On Wed, Jun 27, 2018 at 8:41 AM, Thomas Guillem <thomas at gllm.fr> wrote:
> The idea here is a play a silence corresponding to the difference between the
> first system pts and now. This will be used for aouts that can't start corked,
> so every aout modules except PulseAudio. To reach this new code path, aout
> modules need to return a valid value from the first pf_get_time callback
> (already the case of main modules).
I saw this patch (as well as the thread earlier in the week), and just
wanted to mention that the decklink output also has explicitly
scheduled output for audio. Hence it isn't just PulseAudio that might
be effected by any such patches.
I figure you probably overlooked decklink since it provides an aout
that can be found in modules/video_output/decklink.cpp as opposed to
the typical modules/audio_output directory.
I don't profess to know how/if these patches will have any impact on
the decklink output, but please keep it in mind if you're putting a
bunch of changes in there that apply to "everything but pulseaudio".
Devin J. Heitmueller - Kernel Labs
More information about the vlc-devel