[vlc-devel] [PATCH 2/2] vlc_block: store per block ancillary

Rémi Denis-Courmont remi at remlab.net
Wed Jun 27 19:43:48 CEST 2018

Le keskiviikkona 27. kesäkuuta 2018, 19.58.39 EEST Francois Cartegnie a écrit 
> > Obviously because nobody frees the allocation, or because it gets copied
> > by value.
> Since when block_t struct itself isn't freed ?

I do not like your sarcastic tone.

And by the way "for the umpteenth time", your patch leaks all over.

So, who is laughing now?

> If people copy by value, then that's to be fixed, and use helpers. Just
> like the same issues we had with es_format. (what is the opaque p_extra
> btw ?)

Maybe people should stop throwing the authority argument, making sarcasms, 
diverting attention to red herrings and assuming that the reviewers are 
clueless idiots when they dare to contradict. Maybe other people should also 
stop throwing baseless ad-hominems and proven falsehoods instead of technical 

This patch is totally broken from design to implementation, and I find your 
and JB's attitude appaling.

Реми Дёни-Курмон

More information about the vlc-devel mailing list