[vlc-devel] [V3 2/3] input: add input_SetTime and input_SetPosition

[Thomas Guillem]

Since, there are already lot of input_ functions, I want to push this set as is.

I think it's a core dev job to do the full input_ => vlc_input_ renaming. I can do it when I'll work on the input_manager, errr, vlc_input_manager.

On Wed, Jun 27, 2018, at 08:10, Thomas Guillem wrote:
> 
> On Wed, Jun 27, 2018, at 05:47, Zhao Zhili wrote:
> > 
> > 
> > On 2018年06月26日 16:50, Thomas Guillem wrote:
> > > On Tue, Jun 26, 2018, at 10:20, Rémi Denis-Courmont wrote:
> > >> Le lundi 25 juin 2018, 11:03:49 EEST Zhao Zhili a écrit :
> > >>> ---
> > >>>   include/vlc_input.h        |  4 ++++
> > >>>   src/input/input.c          | 59
> > >>> ++++++++++++++++++++++++++-------------------- src/input/input_internal.h |
> > >>>   9 ++++++-
> > >>>   src/input/var.c            |  6 +++--
> > >>>   src/libvlccore.sym         |  2 ++
> > >>>   5 files changed, 52 insertions(+), 28 deletions(-)
> > >> *Again*, please don't clobber the global namespace more than already.
> > > I said to Zhao it was OK since we already have some input_ functions and I don't want to have vlc_input_ and input_ as prefix for the same input API.
> > >
> > > So, we should we rename all input_ to vlc_input_ ?
> > 
> > I like following the current naming style and do the rename in another 
> > patch group. It doesn't add much burden to the following task. But if 
> > the rename doesn't have a schedule in the near future, I'm fine to add 
> > the vlc_ prefix.
> 
> Agree, I prefer to do the renaming later. Remi ?
> 
> > 
> > >> -- 
> > >> Rémi Denis-Courmont
> > >>
> > >>
> > >> _______________________________________________
> > >> vlc-devel mailing list
> > >> To unsubscribe or modify your subscription options:
> > >> https://mailman.videolan.org/listinfo/vlc-devel
> > > _______________________________________________
> > > vlc-devel mailing list
> > > To unsubscribe or modify your subscription options:
> > > https://mailman.videolan.org/listinfo/vlc-devel
> > 
> > 
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel