[vlc-devel] [RFC PATCH 09/13] FIXUP: implement audio/video/spu delay

[Thomas Guillem]

On Wed, Jun 27, 2018, at 21:06, Rémi Denis-Courmont wrote:
> 	Hi,
> 
> Le keskiviikkona 27. kesäkuuta 2018, 15.41.31 EEST Thomas Guillem a écrit :
> > Each ESses will set the delay to their specific clocks.
> > Setting a delay on the master clock has an effect on all others slaves
> > clocks. Setting a delay on a slave clock has only an effect for the current
> > clock.
> 
> Why can the delay no longer applied/applicable to original PTS? And then, why 
> is the delay not applied within the clock?

In this patch, the delay is applied within the clock, no ?

When do you want to modify the original PTS ? I tried to do that solution first, like we discussed in the meeting, but it seemed very complicated and not easy to implement. Furthermore, I really prefer to keep the original PTS the longer possible. It make it more reactive when changing the delay of subtitles for example (since the core keep a list of subtitles).

> 
> It seems rather repetitive/wasteful to boilerplate this in every clock user.
> 
> -- 
> Реми Дёни-Курмон
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel