[vlc-devel] [RFC PATCH 11/13] FIXUP: slightly improve rate change

Rémi Denis-Courmont remi at remlab.net
Fri Jun 29 12:49:10 CEST 2018


The second half predicate is still useless (not observable) according to C specification.

Le 29 juin 2018 13:01:32 GMT+03:00, Denis Charmet <typx at dinauz.org> a écrit :
>Hi,
>
>On 2018-06-27 21:08, Rémi Denis-Courmont wrote:
>> Le keskiviikkona 27. kesäkuuta 2018, 15.41.33 EEST Thomas Guillem a 
>> écrit :
>>> +    if (!main_clock->master && main_clock->rate != rate)
>>> +        main_clock->rate = rate;
>> 
>> Useless (half) predicate.
>> 
>
>While I agree it's not the most beautiful way to do it, we have to 
>handle case where there is no master (ie clock_monotonic master) and we
>
>want to change the rate.
>
>Regards,
>-- 
>Denis Charmet - TypX
>Le mauvais esprit est un art de vivre
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180629/40601850/attachment.html>


More information about the vlc-devel mailing list