[vlc-devel] [PATCH 0/4 v2] upnp: refactor out UpnpInstanceWrapper

[Shaleen Jain]

Bump. I've made the required changes. Could this please be merged?
On Wed, 2018-06-27 at 17:44 +0530, Shaleen Jain wrote:
> This refactor is required to be able to have multiple
> modules utilizing the libupnp library within VLC
> considering the existing constraints of having only
> one instance of libupnp per process.
> 
> Motivation:
> I plan to add another module (a stream_out module)
> leveraging upnp functionality without having to
> stuff it in an already crammed upnp.cpp
> 
> Shaleen Jain (4):
>   upnp: add and use a callback listener interface
>   upnp: move UpnpInstanceWrapper to upnp-wrapper
>   upnp: rename module callbacks to be more verbose
>   upnp: include config.h from source files
> 
>  modules/services_discovery/Makefile.am      |   4 +-
>  modules/services_discovery/upnp-wrapper.cpp | 161 +++++++
>  modules/services_discovery/upnp-wrapper.hpp | 344 ++++++++++++++
>  modules/services_discovery/upnp.cpp         | 500 ++--------------
> ----
>  modules/services_discovery/upnp.hpp         |  63 +--
>  5 files changed, 566 insertions(+), 506 deletions(-)
>  create mode 100644 modules/services_discovery/upnp-wrapper.cpp
>  create mode 100644 modules/services_discovery/upnp-wrapper.hpp
> 
-- 
Regards,
Shaleen Jain