[vlc-devel] [PATCH v3 1/3] Introduce media source and media tree API

Romain Vimont rom1v at videolabs.io
Fri Jun 29 16:56:26 CEST 2018


On Fri, Jun 29, 2018 at 03:57:28PM +0200, Romain Vimont wrote:
> Thank you for your review. Answers inlined.
> 
> On Fri, Jun 29, 2018 at 03:10:11PM +0300, RĂ©mi Denis-Courmont wrote:
> > I would argue that pf_ is utmostly redundant in an ops table that by 
> > definition contains function pointers :/
> 
> Yes, but many of these hungarian notation prefixes are useless/redundant
> too (TBH, I don't like those prefixes).
> 
> So I just use them for consistency.

I just discussed with Thomas, apparently new code does not use these
prefixes ("i_", "pf_", etc.), or weird space style, like "if( cond )".

So I will do the same and use a more "normal" code style from now :)


More information about the vlc-devel mailing list