[vlc-devel] [PATCH 0/3] Refactoring SRT modules

[Justin Kim]

Hello,

Any advice for these patches? It's been a long time. :)
Please, review and give me advice.

Regards,
Justin

On 30/01/2018 5:13 PM, Justin Kim wrote:
> Hello,
> 
> Once SRT modules lost connection, it should be restarted.
> This refactoring codes are created to prevent that situation.
> 
> While this work, several issues in SRT modules are fixed.
> 
>       - Connection Recovery
>         When lost a SRT connection, this module can detect and try to re-connect.
> 
>       - Interruptible by SRT APIs
>         'srt_epoll_wait' will be interrupted when all socket descriptors
>         are removed from its montoring list. Fortunately, SRT modules are using
>         only one socket.
> 
>       - Platform Independent
>         Now, SRT modules no longer require to use a pipe. Therfore, from this version,
>         SRT modules can support Win32 platforms.
> 
> These are based on code from Roman Diouskine <rdiouskine at haivision.com>
> 
> Justin Kim (3):
>    access_out: srt: Refactoring to support connection recovery
>    access: srt: Refactoring to support connection recovery
>    contrib: srt: Enabled for Win32
> 
>   contrib/src/srt/rules.mak   |   3 +-
>   modules/access/srt.c        | 338 ++++++++++++++++++++++---------------
>   modules/access_output/srt.c | 394 +++++++++++++++++++++++++++-----------------
>   3 files changed, 449 insertions(+), 286 deletions(-)
>