[vlc-devel] [vlc-commits] picture: fix empty allocation leak

[Thomas Guillem]

On Thu, Mar 1, 2018, at 17:15, Rémi Denis-Courmont wrote:
> Le torstaina 1. maaliskuuta 2018, 18.09.42 EET Thomas Guillem a écrit :
> > On Thu, Mar 1, 2018, at 17:05, Rémi Denis-Courmont wrote:
> > > Le torstaina 1. maaliskuuta 2018, 15.48.45 EET Thomas Guillem a écrit :
> > > > On Mon, Feb 26, 2018, at 23:25, Rémi Denis-Courmont wrote:
> > > > > vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Mon Feb
> > > > > 26 23:32:45 2018 +0200| [054bcfe4a97449d57d4f701ef642fdd01b3bcca9] |
> > > > > committer: Rémi Denis-Courmont
> > > > > 
> > > > > picture: fix empty allocation leak
> > > > 
> > > > Hello,
> > > > 
> > > > This commit break opaque decoder pool allocation when the display is
> > > > filtered.
> > > 
> > > No, it does not.
> > 
> > VDPAU is broken, and some other configuration on windows when the display is
> > filtered (D3D9 on D3D11 and vice/versa).
> > 
> > Reverting just this patch fixes the issue.
> 
> Reverting this patch makes VDPAU leak for me (and so, fail if LSAN is active), 
> because aligned_alloc(0) returns non-NULL, but the result is stored nowhere 
> and thus never freed.

Yes I never said "please revert". I just reverted for my debugging process.

> 
> I just trivially messed up so what I pushed is not what I tested.

And thanks for fixing it.

> 
> -- 
> 雷米‧德尼-库尔蒙
> https://www.remlab.net/
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel