[vlc-devel] [vlc-commits] config: assert that option exists
Thomas Guillem
thomas at gllm.fr
Fri Mar 2 13:37:42 CET 2018
On Fri, Mar 2, 2018, at 13:17, Thomas Guillem wrote:
> Hello,
>
> This commit causes a regression. It breaks var_Inherit() on a var that
> is not on config.
>
> Example: "the chain-level" variable from the chain filter.
> Several ways to fix it:
>
> 1/ Check var_Type() from var_Inherit() when doing a fallback on config.
Just sent a patch for solution 1/
>
> 2/ var_Inherit() must be called with a variable that is on the config,
> then we fix the chain.c filter to do a var_Get() on the parent.
>
> I really prefer the 1st solution.
>
> Regards,
>
More information about the vlc-devel
mailing list