[vlc-devel] aout: remove duplicate if tests

Matthew Whitworth mwhitworth at gmail.com
Fri Mar 2 16:23:37 CET 2018


There are a pair of if conditions that are duplicated, cppcheck 1.82
picked this up.
---
diff --git a/src/input/decoder.c b/src/input/decoder.c
index 98817e6f39..5fad585da4 100644
--- a/src/input/decoder.c
+++ b/src/input/decoder.c
@@ -298,8 +298,6 @@ static bool aout_replaygain_changed( const
audio_replay_gain_t *a,
     for( size_t i=0; i<AUDIO_REPLAY_GAIN_MAX; i++ )
     {
         if( a->pb_gain[i] != b->pb_gain[i] ||
-            a->pb_peak[i] != b->pb_peak[i] ||
-            a->pb_gain[i] != b->pb_gain[i] ||
             a->pb_peak[i] != b->pb_peak[i] )
             return true;
     }


More information about the vlc-devel mailing list