[vlc-devel] [PATCH] control: size_t is an unsigned integer

Matthew Whitworth mwhitworth at gmail.com
Fri Mar 2 16:34:55 CET 2018


(resend for correct email title)

cppcheck 1.82 picked this up.

---
diff --git a/src/input/control.c b/src/input/control.c
index 1ecf8529e1..80f86e3a75 100644
--- a/src/input/control.c
+++ b/src/input/control.c
@@ -542,7 +542,7 @@ int input_vaControl( input_thread_t *p_input, int
i_query, va_list args )
             size_t *pi_vout = va_arg( args, size_t * );

             input_resource_HoldVouts( priv->p_resource, ppp_vout, pi_vout );
-            if( *pi_vout <= 0 )
+            if( *pi_vout == 0 )
                 return VLC_EGENERIC;
             return VLC_SUCCESS;
         }


More information about the vlc-devel mailing list