[vlc-devel] control: size_t is an unsigned integer

Hugo Beauzée-Luyssen hugo at beauzee.fr
Fri Mar 2 16:53:29 CET 2018


On Fri, Mar 2, 2018, at 4:28 PM, Matthew Whitworth wrote:
> cppcheck 1.82 picked this up.
> 
> ---
> diff --git a/src/input/control.c b/src/input/control.c
> index 1ecf8529e1..80f86e3a75 100644
> --- a/src/input/control.c
> +++ b/src/input/control.c
> @@ -542,7 +542,7 @@ int input_vaControl( input_thread_t *p_input, int
> i_query, va_list args )
>              size_t *pi_vout = va_arg( args, size_t * );
> 
>              input_resource_HoldVouts( priv->p_resource, ppp_vout, pi_vout );
> -            if( *pi_vout <= 0 )
> +            if( *pi_vout == 0 )
>                  return VLC_EGENERIC;
>              return VLC_SUCCESS;
>          }
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

Both 'control' patches have been applied, however they were originally rejected by git as "corrupted", there might be something wrong in your config!

Thanks!

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr


More information about the vlc-devel mailing list