[vlc-devel] control: size_t is an unsigned integer

Matthew Whitworth mwhitworth at gmail.com
Sat Mar 3 13:28:24 CET 2018

> Sorry but I just don't see what this fixes?
> Insofar as the pi_vout is a pointer to unsigned, the code is exactly the same. 
> This is guaranteed by the ISO C specification. If pi_vout is ever changed to 
> be signed with, say, negative values indicating error, the original code is 
> correct and the patch code is wrong.
> So this really only makes the code actually identically good, and potentially 
> worse. That is not an improvement, if you ask me.

On reflection, I agree. This diff is probably pandering to check tool 
output more than anything else. Better to have that (and disable these 
sorts of checks) then break things silently later on.

Thanks for checking.

More information about the vlc-devel mailing list