[vlc-devel] [vlc-commits] extras/tools: Bump the required protoc version

[Hugo Beauzée-Luyssen]

On Wed, Dec 27, 2017, at 12:07 PM, Martin Storsjö wrote:
> vlc | branch: master | Martin Storsjö <martin at martin.st> | Thu Dec 21 
> 11:37:11 2017 +0200| [bd8de0f76d5b03a01b46400858cdbf20f2e82612] | 
> committer: Jean-Baptiste Kempf
> 
> extras/tools: Bump the required protoc version
> 
> Contribs build protobuf 3.1.0 and assumes that the host environment
> already has got a new enough protoc version.
> 
> Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>
> 
> > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=bd8de0f76d5b03a01b46400858cdbf20f2e82612
> ---
> 
>  extras/tools/bootstrap | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/extras/tools/bootstrap b/extras/tools/bootstrap
> index 93205dea99..7767be0a9e 100755
> --- a/extras/tools/bootstrap
> +++ b/extras/tools/bootstrap
> @@ -80,7 +80,7 @@ check yasm
>  check_tar
>  check ragel
>  check_sed
> -check protoc 2.6.0
> +check protoc 3.1.0
>  check ant
>  check xz
>  check bison 3.0.0
> 

A bit late, but I don't think this is correct/complete.
The contrib pkg check doesn't ensure the version is recent enough, causing us to have incompatible checks.
This is the reason our debian nightly build fails: https://jenkins.videolan.org/job/vlc-nightly/job/vlc-nightly-debian-contrib/

The extras/tools check detect that debian is only shipping 3.0, so we build protoc 3.1.0, but the contrib checks sees a libprotobuf-dev installed, and assumes it's recent enough, while it's actually version 3.0.0, which is incompatible with protoc 3.1.0.

AFAICS, we have too solutions:
- Stop checking for protoc version, and assume that systems that ship the libraries & protoc compiler will ship compatible versions
- Extend the need_pkg function in our contrib system to check for a specific version, and ensure libprotobuf-dev 3.1.0 is available.

I'd tend to favor the 2nd option, but would like to know what you think!

Regards,

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr