[vlc-devel] [PATCH] qt: Set time tooltip to bypass X11 window managers (fixes #20011)
remi at remlab.net
Sat Mar 17 11:50:04 CET 2018
Le lauantaina 17. maaliskuuta 2018, 12.39.39 EET Rémi Denis-Courmont a écrit :
> Le lauantaina 17. maaliskuuta 2018, 12.20.20 EET Josh Sawchuk a écrit :
> > Some window managers (namely i3wm) don't treat the time tooltip's current
> > window flags the same as other window managers. The time tooltip
> > previously
> > used just the FramelessWindowHint flag which is dependant on the window
> > manager to prevent moving & resizing it. i3wm in particular doesn't treat
> > it properly, it can be moved, resized and swallows keyboard events if
> > focused. Adding the X11BypassWindowManagerHint flag prevents any window
> > managers from letting the user move or resize the tooltip and stops it
> > from
> > swallowing events. I tested this on i3wm, gnome shell, xfce window
> > managers
> > and on a Windows 32bit build on Windows 10 and there were no unintended
> > side effects.
> This is a silent revert of ea9923794767e5e65b0cfb3b9b51a2e593c3d75b.
I do personally (still) think that reverting this patch is the correct course
of action. But the revert reference should be included in the comment and the
original bug resolution adjusted.
More information about the vlc-devel