[vlc-devel] [PATCH] configure: Fix shell portability issue

Marvin Scholz epirat07 at gmail.com
Sun Mar 18 03:15:11 CET 2018


On 18 Mar 2018, at 2:51, Kamil Rytarowski wrote:

> The == condition is a non-POSIX extension to shell.
>
> It's not supported on NetBSD and it's a fatal error within the pkgsrc
> framework, even if the condition might be unused.
> ---
>  configure.ac | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index 135266daf8..3a53e04e8d 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -4196,7 +4196,7 @@ AS_IF([test "${SYS}" = "mingw32"], [
>      dnl
>      AC_PATH_PROG([SEVENZIP], [7z], [7z])
>  ])
> -AM_CONDITIONAL(HAVE_MAKENSIS, [test "x$MAKENSIS" != "xno" && test 
> "$nsis_version_ok" == "yes"])
> +AM_CONDITIONAL(HAVE_MAKENSIS, [test "x$MAKENSIS" != "xno" && test 
> "$nsis_version_ok" = "yes"])
>
>  dnl
>  dnl Check wether we have the PROCESS_MITIGATION_IMAGE_LOAD_POLICY
> -- 
> 2.16.2

Thanks, LGTM. Merged.

>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list