[vlc-devel] [PATCH] configure: Make the dirfd(3) check more portable

[Rémi Denis-Courmont]

Le sunnuntaina 18. maaliskuuta 2018, 18.32.39 EET Kamil Rytarowski a écrit :
> On 18.03.2018 17:16, Rémi Denis-Courmont wrote:
> > Le keskiviikkona 14. maaliskuuta 2018, 7.46.15 EET Kamil Rytarowski a 
écrit :
> >> Current POSIX specifies that dirfd(3) shall be a function and optionally
> >> a macro.
> >> 
> >> NetBSD uses traditionally a macro, without a function.
> > 
> > That's a NetBSD bug, and there are no excuses not to fix it.
> > 
> > Besides, VLC already supports the case that dirfd() is a (only) functional
> > macro just fine. When that happens compat/dirfd.c will provide a function
> > to wrap the macro.
> 
> This is not a bug!

Great, then there is no need for a patch.

> autotools has been invented to handle OS mismatch differences.

And stuff are required to be function so you can take pointers to them, and so 
that autoconf and the likes can test for symbols rather than come up with 
unmaintainable ad-hoc compilation checks.

> NetBSD is not a POSIX complaint OS, neither Linux or any other BSD. When
> applicable, every OS goes with its extensions.

Calling a missing feature an extension. I see what you did there.

-- 
雷米‧德尼-库尔蒙
https://www.remlab.net/