[vlc-devel] [PATCH 4/4] intromsg: Ensure non-ascii characters are properly displayed on win32

[Rémi Denis-Courmont]

I don't know why Dummy needs to print the intro message, given that, unlike RC, it can only be started explicitly.

With that said, dummy is used for piping, so it can't read/write there.

Le 20 mars 2018 16:01:19 GMT+02:00, "Hugo Beauzée-Luyssen" <hugo at beauzee.fr> a écrit :
>On Tue, Mar 13, 2018, at 10:06 PM, Rémi Denis-Courmont wrote:
>> Le tiistaina 13. maaliskuuta 2018, 18.17.45 EET Hugo Beauzée-Luyssen
>a écrit :
>> > On Mon, Mar 12, 2018, at 9:58 PM, Rémi Denis-Courmont wrote:
>> > > I cannot see a rationale for moving away from the message log,
>> > 
>> > As described in the mentioned ticket, msg_* doesn't play well with
>non-ascii
>> > character when printing on a windows console
>> 
>> That is not an argument for making a special case of one group out of
>
>> thousands of VLC log calls.
>> 
>> > >  and if piping is supported, this patch will presumably break it.
>> > 
>> > I can't say I tested this, but I'm a bit ensure why this patch
>would break
>> > this?
>> 
>> Obivously, it corrupts the pipe content, unlike the VLC logs.
>> 
>
>Are you referring to the text being printed, or to a technical detail
>of WriteConsole vs OutputDebugString? (Or something else I'm not
>getting)
>
>-- 
>  Hugo Beauzée-Luyssen
>  hugo at beauzee.fr
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180320/74d159f1/attachment.html>