[vlc-devel] [PATCH] Fixed #19993: Made toolTips on Full Screen consistent

[Daksh Shah]

Thanks for your feedback. Kindly have a look at the replies in-line

On Wed, Mar 21, 2018 at 4:28 AM David Fuhrmann <david.fuhrmann at gmail.com>
wrote:

> Hello,
>
> -                _NS("Go to next item"));
> +                _NS("Forward"));
>
> This looks very misleading. This button is about jumping to next item, not
> about forwarding the same item.

I am sorry. I will fix that and change the toolTip to "Next"

>
> Just below, there is another button for "Seek forward“. So you should not
> choose a description which is too close to the other button (as its done in
> your proposal).
>
By proposal you mean this patch right?


> If you compare to the buttons descriptions in the main window: Please note
> that those buttons have different features, depending if only a back and
> forward button is shown, or if  „next“ / „prev“ buttons are shown
> additionally.
>
I understood that now. I think that it is another place where some
enhancement can be done. When the two new buttons show up, the toolTips
remain the same. And the functionalities change. This does not seem
intuitive for new users.
The only reason I realized that was because you pointed it out.

Should I try to change this?


>
>
> -                _NS("Go to the previous item"));
> +                _NS("Backward"));
>
> Same here.
>
>      setupButton(_timeSlider,
>                  _NS("Position"),
> -                _NS("Adjust the current playback position"));
> +                _NS("Position"));
>
> Are you sure choosing the same string for Accessibility title and
> accessibility description is the correct thing to do? I would rather assume
> one might leave the description blank if you actually have no description
> (but I’m just guessing here…)
>
I could not understand properly. The title is what shows up in the toolTip.
But is there a place where the description shows up? I kept it just in case
it might be describing the button in some other place.
If not, I think we should remove it.

>
> BR. David
>
> > Am 19.03.2018 um 12:02 schrieb Daksh Shah <daksh17336 at iiitd.ac.in>:
> >
> > Now the tooltips which are shown in the Normal View are same as the ones
> which are shown in Full-Screen View. Adapted the shorter version.
> > And also, changed the Normal View toolTip of "Fullscreen" to "Enter
> fullscreen"
> >
> >
> <0001-Fixed-19993-Made-toolTips-on-Full-Screen-consistent.patch>_______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180321/88d67e11/attachment.html>