[vlc-devel] [PATCH v3 0/3] Refactoring SRT modules

[Thomas Guillem]

Hello,

There are still several issues for the Windows build:


1/ In your generated src.pc, you need to add /srt folder, see:

-Cflags: -I${includedir} 
+Cflags: -I${includedir} -I${includedir}/srt

I could not find where is was generated in your cmake file.


2/ Add the following in access/Makefile.am access_output/Makefile.am

+libaccess_srt_plugin_la_CFLAGS = $(AM_CFLAGS) $(SRT_CFLAGS)
+libaccess_output_srt_plugin_la_CFLAGS = $(AM_CFLAGS) $(SRT_CFLAGS)


3/ Fix your 0001-srtcore-api.h-change-inet_ntop-to-getnameinfo.patch that has wrong end lines


4/ haicrypt.h is needed but not installed, see the following error code:


In file included from /home/tom/work/git/vlc/contrib/x86_64-w64-mingw32/include/srt/platform_sys.h:11:0,
                 from /home/tom/work/git/vlc/contrib/x86_64-w64-mingw32/include/srt/udt.h:105,
                 from /home/tom/work/git/vlc/contrib/x86_64-w64-mingw32/include/srt/srt.h:28,
                 from ../../extras/package/win32/../../../modules/access/srt.c:38:
/home/tom/work/git/vlc/contrib/x86_64-w64-mingw32/include/srt/win/wintime.h:7:22: fatal error: haicrypt.h: No such file or directory


On Fri, Mar 23, 2018, at 07:59, Justin Kim wrote:
> To build SRT on windows, some patches are cherry-picked from upstream.
> And also, address size assumption codes were removed.
> 
> Justin Kim (3):
>   access_out: srt: Refactoring to support connection recovery
>   access: srt: Refactoring to support connection recovery
>   contrib: srt: Enabled for Win32
> 
>  ...001-CMakeLists.txt-let-cmake-find-pthread.patch |  39 ++
>  .../0001-channel.cpp-add-mswsock.h-for-Win32.patch |  28 ++
>  ...h-Enable-localtime_s-only-if-MSC_VER-1500.patch |  34 ++
>  ...ore-api.h-change-inet_ntop-to-getnameinfo.patch |  43 +++
>  contrib/src/srt/rules.mak                          |  11 +-
>  modules/access/srt.c                               | 341 +++++++++
> +--------
>  modules/access_output/srt.c                        | 396 ++++++++++++
> +--------
>  7 files changed, 603 insertions(+), 289 deletions(-)
>  create mode 100644 contrib/src/srt/0001-CMakeLists.txt-let-cmake-find-
> pthread.patch
>  create mode 100644 contrib/src/srt/0001-channel.cpp-add-mswsock.h-for-
> Win32.patch
>  create mode 100644 contrib/src/srt/0001-srt_compat.h-Enable-
> localtime_s-only-if-MSC_VER-1500.patch
>  create mode 100644 contrib/src/srt/0001-srtcore-api.h-change-inet_ntop-
> to-getnameinfo.patch
> 
> -- 
> 2.16.2
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel