[vlc-devel] [PATCH] ci_filters: Use CIContext without color management

[Thomas Guillem]

On Thu, Mar 22, 2018, at 13:47, Marvin Scholz wrote:
> There seems to be no need to have macOS do color space conversions at
> this point and it fixes the issue where the image would change colors a
> bit when activating a CIFilter even without changing any parameters.

Merged, thanks for the fix.

> ---
>  modules/video_filter/ci_filters.m | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/modules/video_filter/ci_filters.m b/modules/video_filter/
> ci_filters.m
> index 8a8f7a3527..795c907aa5 100644
> --- a/modules/video_filter/ci_filters.m
> +++ b/modules/video_filter/ci_filters.m
> @@ -637,7 +637,10 @@ static void filter_PsychedelicControl(filter_t 
> *filter, struct filter_chain *fch
>          ctx->ci_ctx = [CIContext contextWithCGLContext: glctx
>                                             pixelFormat: nil
>                                              colorSpace: nil
> -                                               options: nil];
> +                                               options: @{
> +                                                
> kCIContextWorkingColorSpace : [NSNull null],
> +                                                
> kCIContextOutputColorSpace : [NSNull null],
> +                                               }];
>  #else
>          CVEAGLContext eaglctx = var_InheritAddress(filter, "ios-
> eaglcontext");
>          if (!eaglctx)
> -- 
> 2.14.3 (Apple Git-98)
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel