[vlc-devel] [PATCH 2/3] demux: h26x: fix frame rate

[Francois Cartegnie]

Le 23/03/2018 à 14:30, Zhao Zhili a écrit :
> Hi,
> 
> Any advice on these patches?

You're mixing both date/rate based timestamps increments,
and original timestamps, defeating the purpose of using date_t, which is
designed to avoid roundings errors.

> 
> On 2018年03月20日 17:17, Zhao Zhili wrote:
>> The packetizer doesn't try to get the real frame rate once a default
>> value is set.
>> ---
>>   modules/demux/mpeg/h26x.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/modules/demux/mpeg/h26x.c b/modules/demux/mpeg/h26x.c
>> index 053040b..0e04d80 100644
>> --- a/modules/demux/mpeg/h26x.c
>> +++ b/modules/demux/mpeg/h26x.c
>> @@ -354,8 +354,8 @@ static int GenericOpen( demux_t *p_demux, const
>> char *psz_module,
>>         /* Load the mpegvideo packetizer */
>>       es_format_Init( &fmt, VIDEO_ES, i_codec );
>> -    fmt.video.i_frame_rate = p_sys->dts.i_divider_num;
>> -    fmt.video.i_frame_rate_base = p_sys->dts.i_divider_den;
>> +    fmt.video.i_frame_rate = p_sys->frame_rate_num;
>> +    fmt.video.i_frame_rate_base = p_sys->frame_rate_den;
>>       p_sys->p_packetizer = demux_PacketizerNew( p_demux, &fmt,
>> psz_module );
>>       if( !p_sys->p_packetizer )
>>       {
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


-- 
Francois Cartegnie
VideoLAN - VLC Developer