[vlc-devel] [PATCH v4 0/3] Refactoring SRT modules

[Thomas Guillem]

Hello,

I have now a link issue with pthread.

I think you need to add -lpthreadGC2 in your generated src.pc for WIN32 (and -lpthread for others ?).

If I add -lpthreadGC2, I can finally build the 2 srt modules on Windows.

On Mon, Mar 26, 2018, at 09:52, Justin Kim wrote:
> Thank you for reviewing. I missed cherry-picking some patches from SRT upstream.
> 
> On 23/03/2018 6:00 PM, Thomas Guillem wrote:
> > 1/ In your generated src.pc, you need to add /srt folder, see:
> Done.
> 
> > 
> > 
> > 2/ Add the following in access/Makefile.am access_output/Makefile.am
> > 
> > +libaccess_srt_plugin_la_CFLAGS = $(AM_CFLAGS) $(SRT_CFLAGS)
> > +libaccess_output_srt_plugin_la_CFLAGS = $(AM_CFLAGS) $(SRT_CFLAGS)
> > 
> Done.
> 
> > 3/ Fix your 0001-srtcore-api.h-change-inet_ntop-to-getnameinfo.patch that has wrong end lines
> > 
> 
> It has crlf end lines, but the original codes have them so I wonder if I 
> need to change the end lines.
> 
> 
> > 4/ haicrypt.h is needed but not installed, see the following error code:
> > 
> > 
> > In file included from /home/tom/work/git/vlc/contrib/x86_64-w64-mingw32/include/srt/platform_sys.h:11:0,
> >                   from /home/tom/work/git/vlc/contrib/x86_64-w64-mingw32/include/srt/udt.h:105,
> >                   from /home/tom/work/git/vlc/contrib/x86_64-w64-mingw32/include/srt/srt.h:28,
> >                   from ../../extras/package/win32/../../../modules/access/srt.c:38:
> > /home/tom/work/git/vlc/contrib/x86_64-w64-mingw32/include/srt/win/wintime.h:7:22: fatal error: haicrypt.h: No such file or directory
> Done.
> 
> Justin Kim (3):
>   access_out: srt: Refactoring to support connection recovery
>   access: srt: Refactoring to support connection recovery
>   contrib: srt: Enabled for Win32
> 
>  ...001-CMakeLists.txt-let-cmake-find-pthread.patch |  39 ++
>  ...0001-Clean-.pc-to-provide-the-dependecies.patch |  46 +++
>  .../srt/0001-Fix-include-path-for-wintime.h.patch  |  64 ++++
>  .../0001-channel.cpp-add-mswsock.h-for-Win32.patch |  28 ++
>  ...h-Enable-localtime_s-only-if-MSC_VER-1500.patch |  34 ++
>  ...ore-api.h-change-inet_ntop-to-getnameinfo.patch |  43 +++
>  contrib/src/srt/rules.mak                          |  13 +-
>  modules/access/Makefile.am                         |   1 +
>  modules/access/srt.c                               | 341 +++++++++
> +--------
>  modules/access_output/Makefile.am                  |   1 +
>  modules/access_output/srt.c                        | 396 ++++++++++++
> +--------
>  11 files changed, 717 insertions(+), 289 deletions(-)
>  create mode 100644 contrib/src/srt/0001-CMakeLists.txt-let-cmake-find-
> pthread.patch
>  create mode 100644 contrib/src/srt/0001-Clean-.pc-to-provide-the-
> dependecies.patch
>  create mode 100644 contrib/src/srt/0001-Fix-include-path-for-
> wintime.h.patch
>  create mode 100644 contrib/src/srt/0001-channel.cpp-add-mswsock.h-for-
> Win32.patch
>  create mode 100644 contrib/src/srt/0001-srt_compat.h-Enable-
> localtime_s-only-if-MSC_VER-1500.patch
>  create mode 100644 contrib/src/srt/0001-srtcore-api.h-change-inet_ntop-
> to-getnameinfo.patch
> 
> -- 
> 2.16.2
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel