[vlc-devel] [PATCH] configure: enable asserts by default

[Thomas Guillem]

On Wed, Mar 28, 2018, at 14:56, Steve Lhomme wrote:
>  From contrib/main.mak
> 
> ifdef WITH_OPTIMIZATION
> HOSTCONF += --disable-dependency-tracking
> else
> HOSTCONF += --enable-debug
> endif
> 
> It seems that the default for most of our contribs is to have debug 
> disabled. So we should keep doing the same.

This part of the mk seems wrong. Enabling debug should not be related at all to optimizations.
Generally, when you are developing, you want debug *and* optimizations.

> 
> 
> Le 28/03/2018 à 14:35, Thomas Guillem a écrit :
> > For 4.0, I propose to finally do the opposite:
> >   - Enable asserts by default (NDEBUG is not defined).
> >   - Disable asserts with --disable-debug for release builds (NDEBUG is defined).
> >
> > Why ? Because too many developers are not using this option that should be
> > mandatory during the development or testing phase.
> > ---
> >   configure.ac | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/configure.ac b/configure.ac
> > index e1a4800ccb..e1f1e8c748 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -952,9 +952,9 @@ dnl
> >   dnl  Debugging mode
> >   dnl
> >   AC_ARG_ENABLE(debug,
> > -  [AS_HELP_STRING([--enable-debug],
> > -    [build with run-time assertions (default disabled)])],,
> > -  [enable_debug="no"])
> > +  [AS_HELP_STRING([--disable-debug],
> > +    [disable run-time assertions (default enabled)])],,
> > +  [enable_debug="yes"])
> >   AH_TEMPLATE(NDEBUG,
> >               [Define to 1 if debug code should NOT be compiled])
> >   AS_IF([test "${enable_debug}" != "no"], [
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel