[vlc-devel] [PATCH] configure: enable asserts by default

[Rémi Denis-Courmont]

Le 28 mars 2018 15:39:27 GMT+03:00, "Hugo Beauzée-Luyssen" <hugo at beauzee.fr> a écrit :
>On Wed, Mar 28, 2018, at 2:35 PM, Thomas Guillem wrote:
>> For 4.0, I propose to finally do the opposite:
>>  - Enable asserts by default (NDEBUG is not defined).
>>  - Disable asserts with --disable-debug for release builds (NDEBUG is
>defined).
>> 
>> Why ? Because too many developers are not using this option that
>should be
>> mandatory during the development or testing phase.
>> ---
>>  configure.ac | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>> 
>> diff --git a/configure.ac b/configure.ac
>> index e1a4800ccb..e1f1e8c748 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -952,9 +952,9 @@ dnl
>>  dnl  Debugging mode
>>  dnl
>>  AC_ARG_ENABLE(debug,
>> -  [AS_HELP_STRING([--enable-debug],
>> -    [build with run-time assertions (default disabled)])],,
>> -  [enable_debug="no"])
>> +  [AS_HELP_STRING([--disable-debug],
>> +    [disable run-time assertions (default enabled)])],,
>> +  [enable_debug="yes"])
>>  AH_TEMPLATE(NDEBUG,
>>              [Define to 1 if debug code should NOT be compiled])
>>  AS_IF([test "${enable_debug}" != "no"], [
>> -- 
>> 2.11.0
>> 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>
>That seems fine and sane to me. We just want to make sure that various
>build.sh scripts are passing --disable-debug when building for releases
>
>-- 
>  Hugo Beauzée-Luyssen
>  hugo at beauzee.fr
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

It is just moving the problem. Either we screw the clueless developper or we screw the clueless packager.
-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.