[vlc-devel] [PATCH 1/2] contrib: mfx: respect the environment CXXFLAGS

[Martin Storsjö]

On Thu, 29 Mar 2018, Martin Storsjö wrote:

> On Thu, 29 Mar 2018, Steve Lhomme wrote:
>
>> Le 29/03/2018 à 09:51, Rémi Denis-Courmont a écrit :
>>> I am somewhat doubtful that mixing C++89 and C++11 compiled code in the 
>> same binary would be reliable.
>> 
>> I would be in favor of removing it too. But Martin may have reasons to 
>> compile the mfx code using this ancient mode.
>
> Well the reason is simple - libmfx and projectM can't be built in C++11 mode 
> right now. If we remove this hardcoding that I did, you'll still get these 
> modules built in C++98 mode if you have a compiler that defaults to that 
> mode, or you'll get a build error for compilers new enough to default to C++ 
>> = 11 (clang 6.0, GCC 6).

FWIW, even if both clang and GCC default to C++ >= 11 now, clang makes 
errors out of a few things that GCC only throws warnings about.

In any case, the C++11 issues in libmfx should be fixed in upstream git 
master now, so you could drop this setting altogether by updating the 
libmfx version - I pushed such a commit.

// Martin