[vlc-devel] [PATCH 1/4] es: move i_profile/i_level to audio and video format structs

Jean-Baptiste Kempf jb at videolan.org
Fri Mar 30 19:19:06 CEST 2018


On Fri, 30 Mar 2018, at 16:29, RĂ©mi Denis-Courmont wrote:
> If it is not the same codec, then don't use the same fourcc.

What is or is not the same codec in DTS?

Is it XCh, XXCh, XBr, XLL different codecs or are the marketing names deciding what is a codec?

Is DTS-ES different from DTS or/and DTS-96?
Is DTS-HD the same codec in HRA or MA?

It's very difficult to explain where to draw the line for DTS and DTS-HD, since it is the same core with different extensions.

> And if you cannot distinguish the codecs, then you cannot fill in a 
> profile value either, so this patch would solve nothing.

Then, do you have a different Codec_Id for AAC and HeAAC, because of the PS and SBR extensions?
Is it a different codec or not?

> I agree. This patch makes no sense.

I disagree: it's a complex problem where there is no clear line, no clear right or wrong.

It makes "some sense", but it does mean it is necessary the best solution. Thomas patch raises a reasonable question.

Also, quoting you, on this very mailing list:
> In other words, if you cannot feed DTS HD to a plugin that expects DTS [core],  then it is a different codec.

Well, you can feed it, for all decoders and for most AVR in PT mode. Some AVR don't support it, and in this case, we could strip the extensions, and that would work with all AVR.


Jean-Baptiste Kempf -  President
+33 672 704 734

More information about the vlc-devel mailing list