[vlc-devel] [PATCH 1/4] es: move i_profile/i_level to audio and video format structs

Rémi Denis-Courmont remi at remlab.net
Fri Mar 30 19:22:57 CEST 2018

Le vendredi 30 mars 2018, 17:36:33 EEST Thomas Guillem a écrit :
> On Fri, Mar 30, 2018, at 16:28, Rémi Denis-Courmont wrote:
> > I agree. This patch makes no sense.
> Do you know the story about the boy who cried "no sense" ?
> Just a little reminder about this following CoC rule:
> "You should, when possible, criticize in private, and praise publicly; since
> most of our communications are public and people can be sensitive about
> that."

A proper and honest code review is done in the same venue and with the same 
audience as the reviewed code. That advice is inapplicable to code review in 
the context of community open-source projects.

Rémi Denis-Courmont

More information about the vlc-devel mailing list