[vlc-devel] [PATCH 1/2] dec: move all callbacks handling in vlc_codec.h

Rémi Denis-Courmont remi at remlab.net
Wed May 16 18:39:28 CEST 2018

Le keskiviikkona 16. toukokuuta 2018, 16.55.19 EEST Francois Cartegnie a écrit 
> Le 16/05/2018 à 14:50, Thomas Guillem a écrit :
> > ---
> I don't see how this helps the next patch.

AFAICT, it does not help the next patch, but it does not hurt it either.

> We had API doing abstraction and we could probably have changed
> callbacks storage to be stored in a dec_t priv struct.

Then we also need a helper to create a decoder_t.

> Now we have inline code requiring exposure of pf_ pointers on the struct.

Uh? I don't see how there is any difference in this respect. The binary 
interface was already exposing those pointers before.

I'd remove the useless pf_ prefixes though.

Rémi Denis-Courmont

More information about the vlc-devel mailing list