[vlc-devel] [PATCH] freetype: Fix compilation on macOS

[Rémi Denis-Courmont]

Le lauantaina 19. toukokuuta 2018, 15.44.52 EEST David Fuhrmann a écrit :
> > Am 19.05.2018 um 14:31 schrieb Rémi Denis-Courmont <remi at remlab.net>:
> > 
> > Le lauantaina 19. toukokuuta 2018, 14.21.24 EEST david.fuhrmann at gmail.com
> > a
> > 
> > écrit :
> >> From: David Fuhrmann <dfuhrmann at videolan.org>
> >> 
> >> Usually, the per-target _LINK variable is autogenerated, taking
> >> into account used languages based on file extension, and also
> >> per-target _LDFLAGS. Due to #17827,_LINK for this module is
> >> explicitly overridden, and therefore the per-target _LDFLAGS are not
> >> respected, which leads to compilation failure.
> > 
> > That problem is not specific to macOS.
> 
> Hi Remi,
> 
> I agree with that.
> 
> Apparently, all the other platforms use libfreetype_plugin_la_LIBADD to
> declare their dependent libraries to link against.

Err well, stating the obvious here but LIBADD is the way to add dependencies 
(at the end of the command line), while LDFLAGS is the way to add other flags, 
at the beginning of the linker command line (and even before that, there is 
also LIBTOOLFLAGS).

But my point is that all platforms use LDFLAGS on the FreeType plugin.

> This variable is still
> added to the final linker line, even if _LINK is overwritten. Thats why it
> works for the other platforms.

So append LDFLAGS to LINK??

-- 
Реми Дёни-Курмон
http://www.remlab.net/