[vlc-devel] [PATCH 3/3] opus: support third order ambisonic with family 2 mapping

Francois Cartegnie fcvlcdev at free.fr
Tue May 22 17:02:27 CEST 2018


> +    unsigned char* p_stream_map;
>      unsigned char new_stream_map[8];
>      decoder_sys_t *p_sys = p_dec->p_sys;
>  
> @@ -328,36 +329,50 @@ static int ProcessInitialHeader( decoder_t *p_dec, ogg_packet *p_oggpacket )
>      msg_Dbg( p_dec, "Opus audio with %d channels", p_header->channels);
>  
>      if((p_header->channels>2 && p_header->channel_mapping==0) ||
> -        p_header->channels>8 ||
> -        p_header->channel_mapping>1)
> +        p_header->channels>18 ||
> +        p_header->channel_mapping>2)
>      {
>          msg_Err( p_dec, "Unsupported channel mapping" );
>          return VLC_EGENERIC;
>      }
                                pi_chan_table );

Obvious new multiple unchecked boundaries w/ potential stack write.

-- 
Francois Cartegnie
VideoLAN - VLC Developer


More information about the vlc-devel mailing list