[vlc-devel] [PATCH 1/8] glx: make GLX_ARB_get_proc_address mandatory
remi at remlab.net
Wed May 23 17:42:26 CEST 2018
Le keskiviikkona 23. toukokuuta 2018, 18.29.59 EEST Thomas Guillem a écrit :
> On Wed, May 23, 2018, at 15:16, Rémi Denis-Courmont wrote:
> > Hmm, so there is a catch-22. We need the extension to load the
> > function provided by the extension.>
> > We can still check at runtime and return an error. If the plugin is
> > loaded lazily, it will prevent aborting on first GPA call. If the
> > plugin is loaded immediately, then loading will fail due to missing
> > GPA (and module subsystem will fall back cleanly).>
> > Either way compiling a module that always fails makes no sense, and
> > would raise warnings.Do we want to complexity the configure.ac to check
> > for this function ?
> I think it's a corner case that is very unlikely to happen for system
> running VLC 4.0, that's why this commit was fine to me.
Then use #error. Knowingly compiling a nonfunctional plugin is silly.
More information about the vlc-devel