[vlc-devel] [PATCH 2/2] opencv_example: fix compilation

[Rémi Denis-Courmont]

Nihao,

It is not such a big deal in VLC as in FFmpeg, as C++ ABI can be restricted to plugins with C++ dependencies - although some devs have taken the unilateral freedom to use C++ even without dependency X-(

What matters is if somebody steps up to update the OpenCV plugin or not. If not, then we should eventually remove it.

Le 24 mai 2018 10:01:20 GMT+03:00, Zhao Zhili <quinkblack at foxmail.com> a écrit :
>
>
>On 2018年04月27日 10:10, Zhao Zhili wrote:
>> ---
>>   modules/video_filter/opencv_example.cpp | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/modules/video_filter/opencv_example.cpp
>b/modules/video_filter/opencv_example.cpp
>> index a7a0bd7..c3a5fe9 100644
>> --- a/modules/video_filter/opencv_example.cpp
>> +++ b/modules/video_filter/opencv_example.cpp
>> @@ -129,7 +129,7 @@ static int OpenFilter( vlc_object_t *p_this )
>>   static void CloseFilter( vlc_object_t *p_this )
>>   {
>>       filter_t *p_filter = (filter_t*)p_this;
>> -    filter_sys_t *p_sys = p_filter->p_sys;
>> +    filter_sys_t *p_sys = static_cast<filter_sys_t
>*>(p_filter->p_sys);
>>   
>>       if( p_sys->p_cascade )
>>           cvReleaseHaarClassifierCascade( &p_sys->p_cascade );
>> @@ -151,7 +151,7 @@ static picture_t *Filter( filter_t *p_filter,
>picture_t *p_pic )
>>       IplImage** p_img = NULL;
>>       CvPoint pt1, pt2;
>>       int scale = 1;
>> -    filter_sys_t *p_sys = p_filter->p_sys;
>> +    filter_sys_t *p_sys = static_cast<filter_sys_t
>*>(p_filter->p_sys);
>>    
>>       if ((!p_pic) )
>>       {
>
>Since we have the same issue as FFmpeg
>http://ffmpeg.org/pipermail/ffmpeg-devel/2018-March/226872.html
>How to deal with the module?
>1. Update to C++ API?
>2. Fix the build issue and hope it works as long as possible?
>3. Remove the module?
>
>
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180524/2405bdda/attachment.html>