[vlc-devel] [PATCH] avcodec: display encoder error only on linux

[Thomas Guillem]

So we should remove the whole dialog and simplify the error message.

On Fri, May 25, 2018, at 10:11, Rémi Denis-Courmont wrote:
> Please stop this nonsense already. This is gping nowhere.
> 
>  The problem is not what OS this is relevant on (and the answer to
>  that is not even "Linux"). The problem is that this code wrongly
>  assumes that all know codecs have an encoder, and in all settings.> 
> Le 25 mai 2018 10:18:57 GMT+03:00, Thomas Guillem <thomas at gllm.fr>
> a écrit :>> This error is only relevant on linux and it's really not needed for
>>>> iOS/macOS/Android.
>> 
>> ---
>> 
>>  modules/codec/avcodec/encoder.c | 2 +-
>> 
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> 
>> 
>> diff --git a/modules/codec/avcodec/encoder.c
>> b/modules/codec/avcodec/encoder.c
>>>> index 87fff6d3c7..761da1a893 100644
>> 
>> --- a/modules/codec/avcodec/encoder.c
>> 
>> +++ b/modules/codec/avcodec/encoder.c
>> 
>> @@ -365,7 +365,7 @@ int InitVideoEnc( vlc_object_t *p_this )
>> 
>>  "*** Please check with your Libav/FFmpeg packager. ***\n"
>> 
>>  "*** This is NOT a VLC media player issue.   ***", psz_namecodec );
>>>>  
>> 
>> -#if !defined(_WIN32)
>> 
>> +#if defined(__linux__)
>> 
>>          vlc_dialog_display_error( p_enc, _("Streaming / Transcoding
>>          failed"), _(
>>>>  /* I have had enough of all these MPEG-3 transcoding bug reports.
>>>>   * Downstream packager, you had better not patch this out, or I will
>>     be really
>>> 
> --
>  Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
>  excuser ma brièveté.> _________________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180525/63462cc0/attachment.html>