[vlc-devel] [PATCH] avcodec: remove the encoder not found dialog

Thomas Guillem thomas at gllm.fr
Fri May 25 10:19:14 CEST 2018


And simplify the error message.
Since we can't assume that all codecs have encoders.
---
 modules/codec/avcodec/encoder.c | 21 +--------------------
 1 file changed, 1 insertion(+), 20 deletions(-)

diff --git a/modules/codec/avcodec/encoder.c b/modules/codec/avcodec/encoder.c
index 87fff6d3c7..7bd20f9e89 100644
--- a/modules/codec/avcodec/encoder.c
+++ b/modules/codec/avcodec/encoder.c
@@ -360,26 +360,7 @@ int InitVideoEnc( vlc_object_t *p_this )
         p_codec = avcodec_find_encoder( i_codec_id );
     if( !p_codec )
     {
-        msg_Err( p_enc, "cannot find encoder %s\n"
-"*** Your Libav/FFmpeg installation is crippled.   ***\n"
-"*** Please check with your Libav/FFmpeg packager. ***\n"
-"*** This is NOT a VLC media player issue.   ***", psz_namecodec );
-
-#if !defined(_WIN32)
-        vlc_dialog_display_error( p_enc, _("Streaming / Transcoding failed"), _(
-/* I have had enough of all these MPEG-3 transcoding bug reports.
- * Downstream packager, you had better not patch this out, or I will be really
- * annoyed. Think about it - you don't want to fork the VLC translation files,
- * do you? -- Courmisch, 2008-10-22 */
-"It seems your Libav/FFmpeg (libavcodec) installation lacks the following encoder:\n"
-"%s.\n"
-"If you don't know how to fix this, ask for support from your distribution.\n"
-"\n"
-"This is not an error inside VLC media player.\n"
-"Do not contact the VideoLAN project about this issue.\n"),
-            psz_namecodec );
-#endif
-
+        msg_Err( p_enc, "cannot find encoder %s\n", psz_namecodec );
         return VLC_EGENERIC;
     }
 
-- 
2.17.0



More information about the vlc-devel mailing list