[vlc-devel] [PATCH] avcodec: remove the encoder not found dialog

[Rémi Denis-Courmont]

I DO NOT KNOW what is the problem with this warning IN RECENT TIMES. Ergo, I do not know what is the proper solution either.

And it does not seem that you do either, or then I wonder why you did not explain it.

Le 25 mai 2018 12:11:35 GMT+03:00, Thomas Guillem <thomas at gllm.fr> a écrit :
>
>On Fri, May 25, 2018, at 11:05, Rémi Denis-Courmont wrote:
>> No and I already explained why.
>
>I still don't get the reason at all.
>
>Packages and distributions are only for LINUX and *BSD, maybe OS/2 ?
>Maybe the if defined(__linux__) is not enough ? Should I add ^^ ?
>
>> 
>> Le 25 mai 2018 11:56:21 GMT+03:00, Thomas Guillem <thomas at gllm.fr>
>> a écrit :>> 
>>> On Fri, May 25, 2018, at 10:53, Rémi Denis-Courmont wrote:
>>>> This is not simplifying. This is removing. It  is even more
>>>> confusing with this patch. Nack.>> 
>>> Yes this is simplifying. Do you expect that an normal VLC users
>>> knowing what is a Libav/FFmeg packager ?>> 
>>> If you disagree with this patch, we need to do it only for linux.
>>> This no such thing as packager on every other OSes (specially since
>>> VideoLAN is packaging VLC for others OS/ports).>> 
>>>> 
>>>> Le 25 mai 2018 11:19:14 GMT+03:00, Thomas Guillem <thomas at gllm.fr>
>a
>>>> écrit :>>>> And simplify the error message.
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>> Since we can't assume that all codecs have encoders.
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>> ---
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>>  modules/codec/avcodec/encoder.c | 21 +--------------------
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>>  1 file changed, 1 insertion(+), 20 deletions(-)
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>> diff --git a/modules/codec/avcodec/encoder.c
>>>>> b/modules/codec/avcodec/encoder.c
>>>>>>>>> 
>>>>> 
>>>>> 
>>>>> index 87fff6d3c7..7bd20f9e89 100644
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>> --- a/modules/codec/avcodec/encoder.c
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>> +++ b/modules/codec/avcodec/encoder.c
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>> @@ -360,26 +360,7 @@ int InitVideoEnc( vlc_object_t *p_this )
>>>>>>>>> 
>>>>> 
>>>>> 
>>>>>          p_codec = avcodec_find_encoder( i_codec_id );
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>>      if( !p_codec )
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>>      {
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>> -        msg_Err( p_enc, "cannot find encoder %s\n"
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>> -"*** Your Libav/FFmpeg installation is crippled.   ***\n"
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>> -"*** Please check with your Libav/FFmpeg packager. ***\n"
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>> -"*** This is NOT a VLC media player issue.   ***",
>>>>> psz_namecodec );
>>>>>>>>> 
>>>>> 
>>>>> 
>>>>> -
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>> -#if !defined(_WIN32)
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>> -        vlc_dialog_display_error( p_enc, _("Streaming /
>>>>>          Transcoding failed"), _(
>>>>>>>>> 
>>>>> 
>>>>> 
>>>>> -/* I have had enough of all these MPEG-3 transcoding bug reports.
>>>>>>>>> 
>>>>> 
>>>>> 
>>>>> - * Downstream packager, you had better not patch this out, or I
>>>>>   will be really
>>>>>>>>> 
>>>>> 
>>>>> 
>>>>> - * annoyed. Think about it - you don't want to fork the VLC
>>>>>   translation files,
>>>>>>>>> 
>>>>> 
>>>>> 
>>>>> - * do you? -- Courmisch, 2008-10-22 */
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>> -"It seems your Libav/FFmpeg (libavcodec) installation lacks the
>>>>> following encoder:\n"
>>>>>>>>> 
>>>>> 
>>>>> 
>>>>> -"%s.\n"
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>> -"If you don't know how to fix this, ask for support from your
>>>>> distribution.\n"
>>>>>>>>> 
>>>>> 
>>>>> 
>>>>> -"\n"
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>> -"This is not an error inside VLC media player.\n"
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>> -"Do not contact the VideoLAN project about this issue.\n"),
>>>>>>>>> 
>>>>> 
>>>>> 
>>>>> -            psz_namecodec );
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>> -#endif
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>> -
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>> +        msg_Err( p_enc, "cannot find encoder %s\n", psz_namecodec
>>>>>          );
>>>>>>>>> 
>>>>> 
>>>>> 
>>>>>          return VLC_EGENERIC;
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>>      } 
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>> 
>>>> --
>>>> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
>>>> excuser ma brièveté.>>>
>_________________________________________________
>>>> vlc-devel mailing list
>>>> To unsubscribe or modify your subscription options:
>>>> https://mailman.videolan.org/listinfo/vlc-devel
>>> 
>> 
>> --
>>  Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
>>  excuser ma brièveté.>
>_________________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180525/4dc11e1f/attachment.html>