[vlc-devel] [PATCH] avcodec: display encoder error only on linux
Rémi Denis-Courmont
remi at remlab.net
Fri May 25 12:14:02 CEST 2018
Sure. Last of many occurrences would probably be the one-time OS/2 support.
Le 25 mai 2018 12:28:42 GMT+03:00, Steve Lhomme <robux4 at ycbcr.xyz> a écrit :
>On 2018-05-25 11:11 AM, Rémi Denis-Courmont wrote:
>> There are many new patch versions because *some* people (Videolabs
>> newbies?) do take review comments into account, and because some
>other
>> people take the easy 5 minutes work feedback into account and royally
>
>> ignore the rest.
>
>Do you have examples of code being pushed despite disagreeing reviews ?
>
>>
>> AFAIR the submission process states that one must either address
>*all*
>> review comments - either in code or in explaining why the reviewer is
>
>> wrong.
>>
>> Le 25 mai 2018 12:03:59 GMT+03:00, Steve Lhomme <robux4 at ycbcr.xyz> a
>> écrit :
>>
>> On 2018-05-25 11:01 AM, Rémi Denis-Courmont wrote:
>>> And that's why I am fed up with explaining things. Because the
>>> reviewee doesn't give a damn and just ignores most of the
>>> explanation.
>>>
>>> In other words, all that talk about me being too terse from a
>few
>>> people here was just convenient excuse, posturing. People just
>>> want a rubber stamp insteaf of a review.
>>
>> Given the amount of "v2" patches on the list I don't think this
>is
>> the case.
>>
>>>
>>> Le 25 mai 2018 11:29:58 GMT+03:00, Thomas Guillem
>>> <thomas at gllm.fr> a écrit :
>>>
>>>
>>> On Fri, May 25, 2018, at 10:24, Rémi Denis-Courmont wrote:
>>>> Err, how about stepping back for once, and pondering why
>>>> this message has become such a problem? It has been there
>>>> for years, with its misleading wording, without causing
>much
>>>> fuss until recently.
>>>
>>> This was done in 2008 because of all the MPEG-3 encoders
>>> missing due to packagers in some Linux distributions.
>>> I really don't think this issue is still relevant 10 years
>>> later. Besides, I found the comment and error message a
>>> little bit aggressive.
>>>
>>>>
>>>> This is a big dark orange flag that something went wrong
>>>> somewhere. Best guesses would be the transcode plugin or
>the
>>>> sout wizard.
>>>>
>>>> And even if it turns out that there are no regression, I
>>>> don't think that failing silently is a good idea.
>>>>
>>>> Le 25 mai 2018 11:12:55 GMT+03:00, Thomas Guillem
>>>> <thomas at gllm.fr> a écrit :
>>>>
>>>> So we should remove the whole dialog and simplify the
>>>> error message.
>>>>
>>>> On Fri, May 25, 2018, at 10:11, Rémi Denis-Courmont
>wrote:
>>>>> Please stop this nonsense already. This is gping
>nowhere.
>>>>>
>>>>> The problem is not what OS this is relevant on (and
>the
>>>>> answer to that is not even "Linux"). The problem is
>>>>> that this code wrongly assumes that all know codecs
>>>>> have an encoder, and in all settings.
>>>>>
>>>>> Le 25 mai 2018 10:18:57 GMT+03:00, Thomas Guillem
>>>>> <thomas at gllm.fr> a écrit :
>>>>>
>>>>> This error is only relevant on linux and it's
>>>>> really not needed for
>>>>>
>>>>>
>>>>> iOS/macOS/Android.
>>>>>
>>>>>
>>>>> ---
>>>>>
>>>>>
>>>>> modules/codec/avcodec/encoder.c | 2 +-
>>>>>
>>>>>
>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> diff --git a/modules/codec/avcodec/encoder.c
>>>>> b/modules/codec/avcodec/encoder.c
>>>>>
>>>>>
>>>>> index 87fff6d3c7..761da1a893 100644
>>>>>
>>>>>
>>>>> --- a/modules/codec/avcodec/encoder.c
>>>>>
>>>>>
>>>>> +++ b/modules/codec/avcodec/encoder.c
>>>>>
>>>>>
>>>>> @@ -365,7 +365,7 @@ int InitVideoEnc( vlc_object_t
>>>>> *p_this )
>>>>>
>>>>>
>>>>> "*** Please check with your Libav/FFmpeg packager.
>>>>> ***\n"
>>>>>
>>>>>
>>>>> "*** This is NOT a VLC media player issue. ***",
>>>>> psz_namecodec );
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> -#if !defined(_WIN32)
>>>>>
>>>>>
>>>>> +#if defined(__linux__)
>>>>>
>>>>>
>>>>> vlc_dialog_display_error( p_enc, _("Streaming /
>>>>> Transcoding failed"), _(
>>>>>
>>>>>
>>>>> /* I have had enough of all these MPEG-3
>>>>> transcoding bug reports.
>>>>>
>>>>>
>>>>> * Downstream packager, you had better not patch
>>>>> this out, or I will be really
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Envoyé de mon appareil Android avec Courriel K-9 Mail.
>>>>> Veuillez excuser ma brièveté.
>>>>> _________________________________________________
>>>>> vlc-devel mailing list
>>>>> To unsubscribe or modify your subscription options:
>>>>> https://mailman.videolan.org/listinfo/vlc-devel
>>>>
>>>>
>>>> --
>>>> Envoyé de mon appareil Android avec Courriel K-9 Mail.
>>>> Veuillez excuser ma brièveté.
>>>> _________________________________________________
>>>> vlc-devel mailing list
>>>> To unsubscribe or modify your subscription options:
>>>> https://mailman.videolan.org/listinfo/vlc-devel
>>>
>>>
>>> --
>>> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
>>> excuser ma brièveté.
>>>
>>>
>>> _______________________________________________
>>> vlc-devel mailing list
>>> To unsubscribe or modify your subscription options:
>>> https://mailman.videolan.org/listinfo/vlc-devel
>>
>>
>> --
>> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
>> excuser ma brièveté.
>>
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
--
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180525/6b191fdc/attachment.html>
More information about the vlc-devel
mailing list