[vlc-devel] [PATCH] configure: Adjust OpenCV version

[Marvin Scholz]

On 15 May 2018, at 19:21, Rémi Denis-Courmont wrote:

> Le sunnuntaina 6. toukokuuta 2018, 18.54.26 EEST Marvin Scholz a 
> écrit :
>> OpenCV 3.x does not support the legacy C interface anymore that VLC 
>> is
>> using, see https://github.com/opencv/opencv/issues/10963
>> ---
>>  configure.ac | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index e507d31694..84fe9a94f6 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -1849,7 +1849,7 @@ PKG_ENABLE_MODULES_VLC([BLURAY], [libbluray],
>> [libbluray >= 0.6.2], (libbluray f dnl
>>  dnl  OpenCV wrapper and example filters
>>  dnl
>> -PKG_ENABLE_MODULES_VLC([OPENCV], [opencv_example opencv_wrapper], 
>> [opencv >
>> 2.0], (OpenCV (computer vision) filter), [auto])
>> +PKG_ENABLE_MODULES_VLC([OPENCV], [opencv_example opencv_wrapper], 
>> [opencv
>>> 2.0 opencv < 3.0], (OpenCV (computer vision) filter), [auto])
>
> This will pull the flags twice though. Use PKG_CHECK_EXISTS.
>

Are you sure it does? I tried it with the pkg-config tool and with that
when specifying the library twice, I only get the flags once, for 
example:

   $ pkg-config --libs "ogg < 1.4 ogg > 1.3.1"
   -L/usr/local/Cellar/libogg/1.3.3/lib -logg

>
> -- 
> 雷米‧德尼-库尔蒙
> http://www.remlab.net/
>
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel