[vlc-devel] [PATCH] access: dtv: Fix variable names in isdbt_setup()

[Akinobu Mita]

2018-05-27 2:51 GMT+09:00 Akinobu Mita <akinobu.mita at gmail.com>:
> The isdbt_setup() attempts to query various variables starting with
> "dvb-a-", "dvb-b-", and "dvb-c-", but the 4th character in the variable

s/4th/6th/

> names (it should be '-') isn't properly initialized.
>
> Signed-off-by: Akinobu Mita <akinobu.mita at gmail.com>
> ---
>  modules/access/dtv/access.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/modules/access/dtv/access.c b/modules/access/dtv/access.c
> index 4af7392526..35c541a96f 100644
> --- a/modules/access/dtv/access.c
> +++ b/modules/access/dtv/access.c
> @@ -870,7 +870,7 @@ static int isdbt_setup (vlc_object_t *obj, dvb_device_t *dev, uint64_t freq)
>      for (unsigned i = 0; i < 3; i++)
>      {
>          char varname[sizeof ("dvb-X-interleaving")];
> -        memcpy (varname, "dvb-X-", 4);
> +        memcpy (varname, "dvb-X-", 6);
>          varname[4] = 'a' + i;
>
>          strcpy (varname + 6, "modulation");
> --
> 2.17.0
>