[vlc-devel] [PATCH 2/2] macosx: Introduce Icecast streaming service

Vibhoothi vibhoothiiaanand at gmail.com
Sat Nov 3 20:24:19 CET 2018


Add proper debug logs for the icecast

fixes #17915
---
 modules/access_output/shout.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/modules/access_output/shout.c b/modules/access_output/shout.c
index d9f8694bdc..7525103424 100644
--- a/modules/access_output/shout.c
+++ b/modules/access_output/shout.c
@@ -207,7 +207,7 @@ static int Open( vlc_object_t *p_this )
          || shout_set_protocol( p_shout, SHOUT_PROTOCOL_ICY ) != SHOUTERR_SUCCESS
          || shout_set_port( p_shout, url.i_port ) != SHOUTERR_SUCCESS
          || shout_set_password( p_shout, url.psz_password ) != SHOUTERR_SUCCESS
-         || shout_set_mount( p_shout, url.psz_path ) != SHOUTERR_SUCCESS
+         || shout_set_mount( p_shout, (url.psz_path != NULL ) ? url.psz_path : "/" ) != SHOUTERR_SUCCESS
          || shout_set_user( p_shout, url.psz_username ) != SHOUTERR_SUCCESS
          || shout_set_agent( p_shout, "VLC media player " VERSION ) != SHOUTERR_SUCCESS
          || shout_set_name( p_shout, psz_name ) != SHOUTERR_SUCCESS
@@ -217,16 +217,14 @@ static int Open( vlc_object_t *p_this )
          /* || shout_set_nonblocking( p_shout, 1 ) != SHOUTERR_SUCCESS */
       )
     {
-        msg_Err( p_access, "failed to initialize shout streaming to %s:%i/%s",
-                 url.psz_host, url.i_port, url.psz_path );
-
+    msg_Err( p_access, "failed to initialize shout streaming to  %s:%i/%s; %s [<Hostname>:<port>/<filePath>;<last shout error that occured in this connection>  eg,http://server:8000/mpd.ogg.m3u; ]",
+                 url.psz_host, url.i_port, url.psz_path,shout_get_error(p_shout) );
         free( psz_name );
         free( psz_description );
         free( psz_genre );
         free( psz_url );
         goto error;
     }
-
     free( psz_name );
     free( psz_description );
     free( psz_genre );
-- 
2.17.1 (Apple Git-112)



More information about the vlc-devel mailing list