[vlc-devel] [vlc-commits] configure: add check for the bitstream project

[Thomas Guillem]

On Tue, Nov 6, 2018, at 03:38, Zhao Zhili wrote:
> On 2018/11/6 上午1:30, Thomas Guillem wrote:
> > vlc | branch: master | Thomas Guillem <thomas at gllm.fr> | Thu Oct 25 10:27:20 2018 +0200| [abf93d8f7815fd3253a57f5660cf0efc470da655] | committer: Thomas Guillem
> >
> > configure: add check for the bitstream project
> >
> >> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=abf93d8f7815fd3253a57f5660cf0efc470da655
> > ---
> >
> >   configure.ac | 6 ++++++
> >   1 file changed, 6 insertions(+)
> >
> > diff --git a/configure.ac b/configure.ac
> > index eeaf3c5efc..5431434c4b 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -3946,6 +3946,12 @@ AS_IF([test "${enable_lirc}" = "yes"], [
> >   AM_CONDITIONAL([HAVE_LIRC], [test "${have_lirc}" = "yes"])
> >   
> >   dnl
> > +dnl  Bitstream
> > +dnl
> > +PKG_CHECK_MODULES([BITSTREAM], [bitstream],[have_bitstream="yes"], [have_bitstream="no"])
> > +AM_CONDITIONAL([HAVE_BITSTREAM], [test "${have_bitstream}" = "yes"])
> 
> The bitstream version is not checked. rist.c requires a header which is 
> on the master branch, not on last release version (1.4). So how to make 
> it work?
> #include <bitstream/ietf/rtcp_sdes.h>

Thanks for this report.
I fixed it by requiring the next bitstream version.

> 
> > +
> > +dnl
> >   dnl  SRT plugin
> >   dnl
> >   PKG_ENABLE_MODULES_VLC([SRT], [access_srt access_output_srt], [srt >= 1.2.2], [SRT input/output plugin], [auto], [], [], [-DENABLE_SRT])
> >
> > _______________________________________________
> > vlc-commits mailing list
> > vlc-commits at videolan.org
> > https://mailman.videolan.org/listinfo/vlc-commits
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel