[vlc-devel] [PATCH] vout: don't redisplay unchanged title on vout reuse

[Rémi Denis-Courmont]

Le torstaina 8. marraskuuta 2018, 20.28.03 EET Francois Cartegnie a écrit :
> Le 08/11/2018 à 19:24, Rémi Denis-Courmont a écrit :
> > Le torstaina 8. marraskuuta 2018, 18.55.46 EET Francois Cartegnie a écrit 
:
> >> ---
> >> 
> >>  src/video_output/video_output.c  | 8 ++++++++
> >>  src/video_output/vout_internal.h | 1 +
> >>  2 files changed, 9 insertions(+)
> > 
> > This looks like a kludge, and I don't even see a justification for it. We
> > are not in the business of second guessing when to show titles. It is
> > entirely possible that the title should be showed.
> 
> Easy: each time the video decoder changes. Adaptive, DVD, bluray...

And that's exactly my point: it's a broken second guessing hack to work around 
a bug in your demuxers.

For instance, if you play one video in a loop, you want the title always (or 
never, in which case you disable it) - not just the first time.

Nack.

-- 
Реми Дёни-Курмон
http://www.remlab.net/