[vlc-devel] [RFC 1/8] libvlc: add a bool return value to the resize callback

Steve Lhomme robux4 at ycbcr.xyz
Tue Nov 20 17:38:05 CET 2018


On 20/11/2018 17:21, Rémi Denis-Courmont wrote:
> Le tiistaina 20. marraskuuta 2018, 17.42.35 EET Steve Lhomme a écrit :
>> For some reason it may be impossible to the host to provide a context with
>> the given size.
> As already explained, this cannot work. We tried that already in the past and
> removed it knowingly. The core has no way to handle rejected resizes, since
> they are asynchronous and already acted upon by the time this callback is
> invoked.
>
> Indeed, the Resize() function would need to pass the error to the caller,
> which it cannot do.

You mean like this ?
https://code.videolan.org/robUx4/vlc/blob/libvlc/callbacks/10/modules/video_output/vgl.c#L72

If it requests an output change (which is also the way the output is 
initialized, which may also fail) and it doesn't care about the error. 
What do you think will happen ?


More information about the vlc-devel mailing list