[vlc-devel] [PATCH] test: increase timeout

[Thomas Guillem]

On Fri, Nov 23, 2018, at 18:32, Rémi Denis-Courmont wrote:
> Hi,
> 
> I fear that an excessively long timeout on deadlocks will discourage
> devs including me from running the test cases.> 
> Maybe we should allow overriding by environment variable so the build
> bots can force longer values?
Yes, I agree, cf. "[PATCH] test: configure timeout with an env variable"
on the ML.
> 
> Le 23 novembre 2018 17:44:36 GMT+02:00, Thomas Guillem
> <thomas at gllm.fr> a écrit :>> The player test can take more than 10 sec if the machine running the
>> test has a
>>>> 
>> 
>> 
>> big load (cf. build bots). test/libvlc/test.h | 2 +-
>> 
>> 
>> 
>> 
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>> diff --git a/test/libvlc/test.h b/test/libvlc/test.h
>> 
>> 
>> 
>> 
>> index 7be53e1417..7ea1b602e4 100644
>> 
>> 
>> 
>> 
>> --- a/test/libvlc/test.h
>> 
>> 
>> 
>> 
>> +++ b/test/libvlc/test.h
>> 
>> 
>> 
>> 
>> @@ -68,7 +68,7 @@ static const char test_default_video[] =
>> SRCDIR"/samples/image.jpg";
>>>> 
>> 
>> 
>>  static inline void test_init (void)
>> 
>> 
>> 
>> 
>>  {
>> 
>> 
>> 
>> 
>>      (void)test_default_sample; /* This one may not be used */
>> 
>> 
>> 
>> 
>> -    alarm (10); /* Make sure "make check" does not get stuck */
>>>> 
>> 
>> 
>> +    alarm (30); /* Make sure "make check" does not get stuck */
>>>> 
>> 
>> 
>>      setenv( "VLC_PLUGIN_PATH", "../modules", 1 );
>> 
>> 
>> 
>> 
>>  } 
>> 
>> 
>> 
>> 
> 
> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
> excuser ma brièveté.> _________________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20181126/0029a7ce/attachment.html>