[vlc-devel] [PATCH 4/6] libvlc: spawn system specific intf after playlist

[Victorien Le Couviour]

Before, the playlist was created on the first call to pl_Get, this is not
the case anymore.
I offer to instantiate the playlist (non-populated) and then the system
default interface.
With this patch the playlist is still populated after the D-Bus code is
evaluated, since afaik
there is only two ways to populate it, either through an interface, or
though the command line.
And the latter is done a bit further in the same function.

On Tue, Nov 27, 2018 at 7:40 PM Rémi Denis-Courmont <remi at remlab.net> wrote:

> Le tiistaina 27. marraskuuta 2018, 14.28.56 EET Victorien Le
> Couviour--Tuffet
> a écrit :
> > The playlist needs to be created before spawning the default system
> > interface since it might use it (to setup playlist / player listeners
> > for instance).
>
> No. The D-Bus code must be evaluated before the playlist is populated.
>
>
> > ---
> >  src/libvlc.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/src/libvlc.c b/src/libvlc.c
> > index 8061171cae..cf35bcfed3 100644
> > --- a/src/libvlc.c
> > +++ b/src/libvlc.c
> > @@ -322,9 +322,6 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int
> > i_argc, var_Create( p_libvlc, "app-version", VLC_VAR_STRING );
> >      var_SetString( p_libvlc, "app-version", PACKAGE_VERSION );
> >
> > -    /* System specific configuration */
> > -    system_Configure( p_libvlc, i_argc - vlc_optind, ppsz_argv +
> vlc_optind
> > ); -
> >  #ifdef ENABLE_VLM
> >      /* Initialize VLM if vlm-conf is specified */
> >      psz_parser = var_InheritString( p_libvlc, "vlm-conf" );
> > @@ -343,6 +340,9 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int
> > i_argc,
> >
> >      PlaylistConfigureFromVariables(priv->main_playlist,
> > VLC_OBJECT(p_libvlc));
> >
> > +    /* System specific configuration */
> > +    system_Configure( p_libvlc, i_argc - vlc_optind, ppsz_argv +
> vlc_optind
> > ); +
> >      /*
> >       * Load background interfaces
> >       */
>
>
> --
> 雷米‧德尼-库尔蒙
> http://www.remlab.net/
>
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20181128/063c38a3/attachment.html>